Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to provide your own MDCAdapter #916

Open
patrickjamesbarry opened this issue Feb 3, 2025 · 0 comments
Open

Provide a way to provide your own MDCAdapter #916

patrickjamesbarry opened this issue Feb 3, 2025 · 0 comments

Comments

@patrickjamesbarry
Copy link

We are trying to use LogbackServiceProvider, but provide our own MDCAdapter that extends LogbackMDCAdapter. However, because of the way LogbackServiceProvider news up a its own LogbackMdcAdapter (in the initialize method), and does not use a 'getter' when referencing it, it prevents devs from being able to override the MdcAdapter. We see a dependency on the MDCAdapter has to be an instanceOf LogbackMdcAdapter, which should be ok for us, since ware extending that class.

This forces a dev to have to create an entire implementation of SLF4JServiceProvider, when all they want to do is provice a custom MDCAdapter

Also reported: https://jira.qos.ch/browse/LOGBACK-1496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant