Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logback 1.5.13, 1.5.14 1.5.15 1.5.16 EvaluatorFilter configuration not working #925

Open
arrowwind opened this issue Feb 12, 2025 · 2 comments
Assignees
Labels

Comments

@arrowwind
Copy link

logback.xml:


%msg%n




if(level > DEBUG) {
return true;
}else{
return false;
}


ACCEPT
DENY

java file:
LOGGER.debug("Not show!");

In version 1.5.13, 1.5.14 ,1.5.15 ,1.5.16 "the not show!" is printed, which should not be there.

Please fix. Thank you.

@ceki ceki self-assigned this Feb 12, 2025
@ceki ceki added the UNCLEAR label Feb 12, 2025
@ceki
Copy link
Member

ceki commented Feb 12, 2025

@arrowwind This report looks very much incomplete and quite incomprehensible. Can you please complete it?

@qos-ch qos-ch deleted a comment from arrowwind Feb 12, 2025
@ceki
Copy link
Member

ceki commented Feb 12, 2025

As mentioned on the janino expression migrator page, make sure to include only the boolean expression itself, i.e. the contents within the <expression> element nested within the <evaluator> element (implicitly of class JaninoEventEvaluator) nested within <filter> element of class EvaluatorFilter.

In you case, the boolean expression to migrate is:

if(level > DEBUG) {
   return true;
 } else {
   return false;
}

@arrowwind Please acknowledge so that the issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants