SLF4J 1.7 and 2.0 are not fully binary compatible #326
jcompagner
started this conversation in
General
Replies: 2 comments 1 reply
-
Correct, this change is a bummer for upgrading. |
Beta Was this translation helpful? Give feedback.
0 replies
-
this was already set straight in: https://jira.qos.ch/browse/SLF4J-577 so getMarker() was not a client api (so client using the logger) |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In the docs i think this is said that it is a drop in replacement
and for the most part i think it is.
but there is a change:
1.7:
https://github.com/qos-ch/slf4j/blob/e9ee55cca93c2bf26f14482a9bdf961c750d2a56/slf4j-api/src/main/java/org/slf4j/event/LoggingEvent.java
2.0:
https://github.com/qos-ch/slf4j/blob/f85104040ce44ac545e15e4f41ef771a7a7f7add/slf4j-api/src/main/java/org/slf4j/event/LoggingEvent.java
so getMarker() is removed (getMarkers() is added)
shouldn't getMarker() just stay there (and maybe marked as deprecated) ?
Beta Was this translation helpful? Give feedback.
All reactions