Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt3scan: improve scan saves #76

Closed
gadamc opened this issue Feb 1, 2023 · 6 comments
Closed

qt3scan: improve scan saves #76

gadamc opened this issue Feb 1, 2023 · 6 comments
Labels
code improvement enhancement New feature or request

Comments

@gadamc
Copy link
Collaborator

gadamc commented Feb 1, 2023

Confocal scans should be saved with more information than is currently saved.

Presently we only save the measured count rates in a simple 2D numpy array.

Ideally, we should save the following per stage position

  • raw number of counts
  • count rate

into a 2D array.

Additionally, at a minimum we should save the scan range and resolution. And we could envision the usefulness of also saving other data acquisition parameters, such as clock sample rate, and number of clock samples per position.

There is also a push to save data in hdfs format - see issue #67 - which we could consider doing in this ticket.

To accomplish these goals we would need to

  • modify NiDaqDigitalInputRateCounter without side-effects on qt3scope and the experiment classes such that the raw counts can be returned as well as the count rate for each scan position
  • modify the piezoScanner so that it holds both the raw data counts and the count rate (or perhaps, equivalently, the raw data counts and the sample time, allowing for easy computation of the count rate)
  • ScanImage class in piezoscan.py holds the necessary data
  • add h5py as requirement
  • update piezoscan.py save data function to package data into h5py
  • need some kind of documentation and/or class to define our h5py data structure(?)

If we work on this issue, then Issue #67 and Issue #35 should be closed. Or Issue #67 can be re-written just to define the work to incorporate the qt3experimentmanager tool.

@gadamc
Copy link
Collaborator Author

gadamc commented Feb 1, 2023

An alternative is not to use h5py but instead serialize to JSON and native python data types. @mfparsons314 what are the reasons to move to h5py?

@mfparsons314
Copy link
Contributor

mfparsons314 commented Feb 1, 2023 via email

@gadamc
Copy link
Collaborator Author

gadamc commented Feb 1, 2023

@mfparsons314 do you envision using hdf5 file format in a way that would store ALL of the data for a single sample? That is, in a single file you'll have multiple confocal scans and multiple spectra taken over the lifetime of that sample?

@mfparsons314
Copy link
Contributor

mfparsons314 commented Feb 1, 2023 via email

@gadamc gadamc added enhancement New feature or request code improvement labels Feb 3, 2023
@gadamc
Copy link
Collaborator Author

gadamc commented Feb 3, 2023

This is currently in PR #81

@gadamc
Copy link
Collaborator Author

gadamc commented Feb 8, 2023

fixed in PR #81

@gadamc gadamc closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants