Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched data/benchmark dates creates an error at the end of simulation #971

Closed
jlowin opened this issue Jan 24, 2016 · 1 comment
Closed

Comments

@jlowin
Copy link
Contributor

jlowin commented Jan 24, 2016

As described in loader.py, benchmark returns are cut off 2 days before the current trading day. But if users run algorithms with a data source that includes the most recent trading days, it creates an error during the risk calculations at the end of the simulation, because the "extra" day will get nan for the benchmark return.

It's happening this weekend: zipline.data.load_from_yahoo() is returning data through 1/21, but the last benchmark return from loader.load_market_data is 1/20.

@freddiev4
Copy link
Contributor

The data is filled through the current trading day (x-ref #2044) so going to close this; we also don't use load_from_yahoo() anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants