Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficient JSON serialization of FrozenCircuit #3633

Closed
95-martin-orion opened this issue Dec 30, 2020 · 1 comment
Closed

Efficient JSON serialization of FrozenCircuit #3633

95-martin-orion opened this issue Dec 30, 2020 · 1 comment
Labels
area/serialization area/subcircuits kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@95-martin-orion
Copy link
Collaborator

Is your feature request related to a use case or problem? Please describe.

Part of #3235.
Concise serialization (#3601) is available for Cirq objects, but not yet supported for FrozenCircuit.

Describe the solution you'd like

FrozenCircuit needs the _serialization_key_ magic method to enable efficient serialization. This should be a fairly small code change, but may require nontrivial updates to its JSON serialization test.

What is the urgency from your perspective for this issue? Is it blocking important work?

P1 - I need this no later than the next release (end of quarter)
@95-martin-orion 95-martin-orion mentioned this issue Jan 8, 2021
Closed
@95-martin-orion
Copy link
Collaborator Author

Also part of #3438.

@95-martin-orion 95-martin-orion added the triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on label Jan 19, 2021
@95-martin-orion 95-martin-orion mentioned this issue Feb 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/serialization area/subcircuits kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
2 participants
@MichaelBroughton @95-martin-orion