Avro code generation not triggering in 2.5 line

[languitar]

We have a project including the quarkus-avro extension. With Quarkus 2.4.1, code generation from avsc files is automatically triggered. With 2.5.x nothing happens and the whole Quarkus generate-code Maven goal is not triggered:

product-schema-service on  feature/POE-4482-send-ev… [$!?] via ☕ v11.0.13 via  v17.1.0 ☸ admin@staging (team-ccc)
❯ mvn clean generate-sources
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------< one.plan:product-schema-service >-------------------
[INFO] Building product-schema-service 2.7.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ product-schema-service ---
[INFO] Deleting /home/languitar/src/product-schema-service/target
[INFO]
[INFO] --- quarkus-maven-plugin:2.4.1.Final:generate-code (default) @ product-schema-service ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.348 s
[INFO] Finished at: 2021-12-08T12:22:03+01:00
[INFO] ------------------------------------------------------------------------

product-schema-service on  feature/POE-4482-send-ev… [$!?] via ☕ v11.0.13 via  v17.1.0 ☸ admin@staging (team-ccc) took 4s
❯ vim pom.xml

product-schema-service on  feature/POE-4482-send-ev… [$!?] via ☕ v11.0.13 via  v17.1.0 ☸ admin@staging (team-ccc) took 3s
❯ mvn clean generate-sources
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true -Dswing.defaultlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------< one.plan:product-schema-service >-------------------
[INFO] Building product-schema-service 2.7.0
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ product-schema-service ---
[INFO] Deleting /home/languitar/src/product-schema-service/target
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.863 s
[INFO] Finished at: 2021-12-08T12:22:12+01:00
[INFO] ------------------------------------------------------------------------

Did anything change in the way the Quarkus maven plugin has to be configured with 2.5 to get this going again?

[maxandersen]

/cc @cescoffier

[cescoffier]

Try to change the phase to 'process-resources', and make sure that the Quarkus plugin is defined before kotlin in the pom.

I'm looking with the person that changed the phase, because I fear you are the first of many that will face this issue.

[languitar]

While debugging this I had already searched the migration guide in something like this but didn't find anything like that. At least adding a note there could rescue some others hitting this, too.

[cescoffier]

I agree, but let's make sure we have a working setup.

[Jeinhaus]

Changing process-sources to process-resources worked for me. IntelliJ now highlights process-resources with the hint "Kotlin plugin should run before javac so kotlin classes could be visible from Java" and suggests adding this block to the maven-compiler-plugin:

                 <executions>
                    <execution>
                        <id>compile</id>
                        <phase>compile</phase>
                        <goals>
                            <goal>compile</goal>
                        </goals>
                    </execution>
                    <execution>
                        <id>testCompile</id>
                        <phase>test-compile</phase>
                        <goals>
                            <goal>testCompile</goal>
                        </goals>
                    </execution>
                </executions>

[languitar]

@Jeinhaus is working on the same project. So this also works for me.

[cescoffier]

The problem is related to the Maven phases and the fact that the Kotlin compilation was happening before the Avro generation.
The right order is the following:

[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ avro-kotlin ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO]
[INFO] --- quarkus-maven-plugin:2.5.1.Final:generate-code (default) @ avro-kotlin ---  <---- Quarkus Avro generation
[INFO]
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ avro-kotlin ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- kotlin-maven-plugin:1.5.31:compile (compile) @ avro-kotlin ---              <---- Kotlin compilation
[INFO] Applied plugin: 'all-open'

Projects generated from https://code.quarkus.io configure the project correctly. The pom.xml file should contain:

<plugins>
      <plugin>
        <groupId>${quarkus.platform.group-id}</groupId>
        <artifactId>quarkus-maven-plugin</artifactId>
        <version>${quarkus.platform.version}</version>
        <extensions>true</extensions>
        <executions>
          <execution>
            <goals>
              <goal>build</goal>
              <goal>generate-code</goal>
              <goal>generate-code-tests</goal>
            </goals>
          </execution>
        </executions>
      </plugin>
      ...
      <plugin>
        <groupId>org.jetbrains.kotlin</groupId>
        <artifactId>kotlin-maven-plugin</artifactId>
        <version>${kotlin.version}</version>
        <executions>
          <execution>
            <id>compile</id>
            <goals>
              <goal>compile</goal> <!-- bound to the compile phase, after the Quarkus Avro generation -->
            </goals>
          </execution>
          <execution>
            <id>test-compile</id>
            <goals>
              <goal>test-compile</goal>
            </goals>
          </execution>
        </executions>
        <dependencies>
          <dependency>
            <groupId>org.jetbrains.kotlin</groupId>
            <artifactId>kotlin-maven-allopen</artifactId>
            <version>${kotlin.version}</version>
          </dependency>
        </dependencies>
        <configuration>
          <javaParameters>true</javaParameters>
          <jvmTarget>11</jvmTarget>
          <compilerPlugins>
            <plugin>all-open</plugin>
          </compilerPlugins>
          <pluginOptions>
            <option>all-open:annotation=javax.ws.rs.Path</option>
            <option>all-open:annotation=javax.enterprise.context.ApplicationScoped</option>
            <option>all-open:annotation=io.quarkus.test.junit.QuarkusTest</option>
          </pluginOptions>
        </configuration>
      </plugin>
    </plugins>

[languitar]

Thanks, I have actually no idea why the kotlin compiler was bound to that phase. This exists from the beginning of the git history in this project.