Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command - tolerate non-quarkus modules in multi-module project #43405

Open
rsvoboda opened this issue Sep 20, 2024 · 1 comment
Open
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/enhancement New feature or request

Comments

@rsvoboda
Copy link
Member

Description

Update command should be able to tolerate non-quarkus modules in multi-module project

I hit that with quarkus-super-heroes when I tried to update it to the latest Quarkus version

Reproducer:

git clone https://github.com/quarkusio/quarkus-super-heroes -b 3.8.Final
cd quarkus-super-heroes
mvn io.quarkus:quarkus-maven-plugin:3.14.4:update

The command ends on scripts/jmeter module saying [ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:3.14.4:update (default-cli) on project jmeter-scripts: Failed to apply the updates: Project Java version not detected, set maven.compiler.release property in your build file to fix the error. -> [Help 1]

When I add the property, it ends with [ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:3.14.4:update (default-cli) on project jmeter-scripts: Failed to apply the updates: The project does not import any Quarkus platform BOM -> [Help 1]

Quarkus update tooling should be able handle multi-module projects that are not necessarily 100% Quarkus based.

Implementation ideas

N/A

@rsvoboda rsvoboda added the kind/enhancement New feature or request label Sep 20, 2024
@geoand geoand added area/cli Related to quarkus cli (not maven/gradle/etc.) and removed triage/needs-triage labels Sep 20, 2024
Copy link

quarkus-bot bot commented Sep 20, 2024

/cc @ebullient (cli), @maxandersen (cli)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants