Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store GetEmptyTicksForEpochs should use an Iter #90

Open
0xluk opened this issue Jan 2, 2025 · 0 comments
Open

store GetEmptyTicksForEpochs should use an Iter #90

0xluk opened this issue Jan 2, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@0xluk
Copy link
Contributor

0xluk commented Jan 2, 2025

What? Why? Who?

Due to the fact that we had performance issues in the /v1/status endpoint identified in #83, after we narrowed it down, we came to the conclusion that the GetEmptyTicksForEpochs was taking a lot of CPU time when an archiver instance has a lot of epochs stored.

How?

Instead of using multiple Get in a for loop, getting multiple epochs (keys) empty ticks should be done by using an iterator which is far more efficient.

Acceptance Criteria

The same data as before needs to be returned and hotfix implementation(/v1/status returns only current tick of the epoch now, included here: 36d5326) needs to be reverted

@0xluk 0xluk added this to integration Jan 2, 2025
@0xluk 0xluk moved this to Backlog in integration Jan 3, 2025
@0xluk 0xluk moved this from Backlog to Ready in integration Jan 8, 2025
@qubicmio qubicmio added the bug Something isn't working label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

2 participants