Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Juno integration #90

Closed
davidanthoff opened this issue Jun 5, 2018 · 4 comments · Fixed by #257
Closed

Improve Juno integration #90

davidanthoff opened this issue Jun 5, 2018 · 4 comments · Fixed by #257
Milestone

Comments

@davidanthoff
Copy link
Member

Main thing would be to get the interactive stuff working.

@davidanthoff davidanthoff added this to the Backlog milestone Jun 5, 2018
@pfitzseb
Copy link

pfitzseb commented Jun 5, 2018

For reference: JunoLab/Juno.jl#125 (comment)

Juno's API for things like this will (hopefully) change drastically soon since I'm hoping to get rid of the Blink.jl dependency... I can take another look at this then.

@davidanthoff
Copy link
Member Author

Would be great if we could take another look at this, given for example https://discourse.julialang.org/t/vega-lite-width-and-height-in-heatmap-in-juno-sometimes-doesnt-work/33262/4.

@pfitzseb, I haven't followed the Juno plot story, I assume it is now using MIME types and the normal display stuff? In VS Code and ElectronDisplay.jl we just support the vega and vega-lite MIME types out of the box (essentially emulating JupyterLab and nteract). So we ship the javascript client libraries that are need to display these MIME types as part of these clients, and then get interactivity that way. What would our current options for Juno be? Similar story, or something else?

@pfitzseb
Copy link

So in theory

function Base.show(io::IO, m::MIME"application/prs.juno.plotpane+html", v::VegaLite.VGSpec)
    VegaLite.writehtml_full(io, v)
end

function Base.show(io::IO, m::MIME"application/prs.juno.plotpane+html", v::VegaLite.VLSpec)
    VegaLite.writehtml_full(io, v)
end

should work, except for the fact that writehtml_full doesn't have a method for VLSpec/VGSpec.

@davidanthoff
Copy link
Member Author

That is perfect! I know how to sort out the details inside those functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants