From 68633ef4470ff13a1e3a65242da2d4b9d5186c88 Mon Sep 17 00:00:00 2001 From: Jan Britz Date: Mon, 29 Jul 2024 14:38:40 +0200 Subject: [PATCH] refactor: simplify if-clause --- classes/question_ui_renderer.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/classes/question_ui_renderer.php b/classes/question_ui_renderer.php index 0e47aaef..3ce99f1f 100644 --- a/classes/question_ui_renderer.php +++ b/classes/question_ui_renderer.php @@ -130,9 +130,10 @@ private function hide_unwanted_feedback(): void { $feedback = $element->getAttributeNS(constants::NAMESPACE_QPY, "feedback"); if ( - !in_array($feedback, ["general", "specific"]) - || ($feedback == "general" && !$this->options->generalfeedback) - || ($feedback == "specific" && !$this->options->feedback) + !( + ($feedback == "general" && $this->options->generalfeedback) + || ($feedback == "specific" && $this->options->feedback) + ) ) { $element->parentNode->removeChild($element); }