From ab04ec940f960bbbb709a0a4ed9da38885e8d522 Mon Sep 17 00:00:00 2001 From: Matthew Glazar Date: Sat, 17 Feb 2024 18:09:17 -0500 Subject: [PATCH] fix(vscode): fix corrupted VS Code downloads in testing 'yarn test' downloads Visual Studio Code into a temporary directory. A change in Visual Studio Code's server caused the download to break [1]. Example error message on Windows: Test error: Error: spawn P:\quick-lint-js\plugin\vscode\.vscode-test\vscode-win32-x64-archive-1.55.2\Code.exe ENOENT Exit code: -4058 Fix the broken downloading by applying a patch to the download script [2]. [1] https://github.com/microsoft/vscode-test/issues/246 [2] https://github.com/microsoft/vscode-test/commit/62881f0aba43c97734dd540b304569e45269dd18 --- plugin/vscode/package.json | 2 +- plugin/vscode/yarn.lock | 19 +++++++++++++------ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/plugin/vscode/package.json b/plugin/vscode/package.json index f485ec84bd..3c496e7ade 100644 --- a/plugin/vscode/package.json +++ b/plugin/vscode/package.json @@ -80,7 +80,7 @@ "test": "node test/run-vscode-tests.js" }, "devDependencies": { - "@vscode/test-electron": "2.3.0", + "@vscode/test-electron": "2.3.9", "colors": "1.4.0", "prettier": "2.8.4", "vsce": "2.15.0" diff --git a/plugin/vscode/yarn.lock b/plugin/vscode/yarn.lock index 5eeac1097e..60ec01d5fc 100644 --- a/plugin/vscode/yarn.lock +++ b/plugin/vscode/yarn.lock @@ -7,15 +7,15 @@ resolved "https://registry.yarnpkg.com/@tootallnate/once/-/once-1.1.2.tgz#ccb91445360179a04e7fe6aff78c00ffc1eeaf82" integrity sha512-RbzJvlNzmRq5c3O09UipeuXno4tA1FE6ikOjxZK0tuxVv3412l64l5t1W5pj4+rJq9vpkm/kwiR07aZXnsKPxw== -"@vscode/test-electron@2.3.0": - version "2.3.0" - resolved "https://registry.yarnpkg.com/@vscode/test-electron/-/test-electron-2.3.0.tgz#de0ba2f5d36546a83cd481b458cbdbb7cc0f7049" - integrity sha512-fwzA9RtazH1GT/sckYlbxu6t5e4VaMXwCVtyLv4UAG0hP6NTfnMaaG25XCfWqlVwFhBMcQXHBCy5dmz2eLUnkw== +"@vscode/test-electron@2.3.9": + version "2.3.9" + resolved "https://registry.yarnpkg.com/@vscode/test-electron/-/test-electron-2.3.9.tgz#f61181392634b408411e4302aef6e1cd2dd41474" + integrity sha512-z3eiChaCQXMqBnk2aHHSEkobmC2VRalFQN0ApOAtydL172zXGxTwGrRtviT5HnUB+Q+G3vtEYFtuQkYqBzYgMA== dependencies: http-proxy-agent "^4.0.1" https-proxy-agent "^5.0.0" jszip "^3.10.1" - semver "^7.3.8" + semver "^7.5.2" agent-base@6: version "6.0.2" @@ -676,13 +676,20 @@ semver@^5.1.0: resolved "https://registry.yarnpkg.com/semver/-/semver-5.7.1.tgz#a954f931aeba508d307bbf069eff0c01c96116f7" integrity sha512-sauaDf/PZdVgrLTNYHRtpXa1iRiKcaebiKQ1BJdpQlWH2lCvexQdX55snPFyK7QzpudqbCI0qXFfOasHdyNDGQ== -semver@^7.3.5, semver@^7.3.8: +semver@^7.3.5: version "7.3.8" resolved "https://registry.yarnpkg.com/semver/-/semver-7.3.8.tgz#07a78feafb3f7b32347d725e33de7e2a2df67798" integrity sha512-NB1ctGL5rlHrPJtFDVIVzTyQylMLu9N9VICA6HSFJo8MCGVTMW6gfpicwKmmK/dAjTOrqu5l63JJOpDSrAis3A== dependencies: lru-cache "^6.0.0" +semver@^7.5.2: + version "7.6.0" + resolved "https://registry.yarnpkg.com/semver/-/semver-7.6.0.tgz#1a46a4db4bffcccd97b743b5005c8325f23d4e2d" + integrity sha512-EnwXhrlwXMk9gKu5/flx5sv/an57AkRplG3hTK68W7FRDN+k+OWBj65M7719OkA82XLBxrcX0KSHj+X5COhOVg== + dependencies: + lru-cache "^6.0.0" + setimmediate@^1.0.5: version "1.0.5" resolved "https://registry.yarnpkg.com/setimmediate/-/setimmediate-1.0.5.tgz#290cbb232e306942d7d7ea9b83732ab7856f8285"