hyprland/ipc: fix parsing order of windowTitle and windowClass in openwindow handler #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dler The openwindow event format is ADDRESS,WORKSPACE,CLASS,TITLE but the handler was parsing args.at(2) as title and args.at(3) as class, which is reversed. This caused windows to display their class name instead of their actual title when the openwindow event arrived after windowtitlev2, since updateInitial would overwrite the correct title with the class.
nemalex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
openwindowevent format isWINDOWADDRESS,WORKSPACENAME,WINDOWCLASS,WINDOWTITLE, but the handler was parsingargs.at(2)as title andargs.at(3)as class, which is reversed.This caused windows to display their class name instead of their actual title when the
openwindowevent arrived afterwindowtitlev2, sinceupdateInitialwould overwrite the correct title with the class.Link to official IPC format: https://wiki.hypr.land/IPC/#events-list