Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for all Tantivy query methods #20

Open
theblackcat102 opened this issue Mar 12, 2020 · 10 comments
Open

Support for all Tantivy query methods #20

theblackcat102 opened this issue Mar 12, 2020 · 10 comments
Labels
enhancement New feature or request feature-parity Feature parity with upstream tantivy help wanted Extra attention is needed

Comments

@theblackcat102
Copy link

Will there be support for other query method such as PhraseQuery, FuzzyTermQuery, RangeQuery?

@poljar
Copy link
Contributor

poljar commented Mar 14, 2020

I don't have any plans to work on this myself, at least not for now.

Contributions of course are always welcome.

@poljar poljar added the enhancement New feature or request label Mar 14, 2020
@GuillaumePressiat
Copy link

GuillaumePressiat commented Nov 26, 2023

Hi,

How to contribute then ?
I don't see python code in the repo.

fuzzy matching absence is a no go for using tantivy in python even though tantivy seems very powerful.

Many thanks,
Guillaume

@mocobeta
Copy link
Contributor

Hi guys!
I'd like to contribute to this issue. For a good starter, I've already opened #175. ;) Could anyone review it?

@cjrh
Copy link
Collaborator

cjrh commented Dec 30, 2023

#175 has been merged. I think either we should have a checklist of remaining query methods on this issue, or we create new separate enhancement issues for each of the remaining ones. Which is better?

@mocobeta
Copy link
Contributor

There are several Query classes in Tantivy.
https://docs.rs/tantivy/latest/tantivy/query/trait.Query.html#impl-Query-for-Box%3Cdyn+Query%3E

I think having a checklist is a great idea on this issue.

@mocobeta
Copy link
Contributor

mocobeta commented Dec 31, 2023

I made a simple checklist to support all Tantivy queries (I don't have permission to edit the issue description.)

@cjrh cjrh added help wanted Extra attention is needed feature-parity Feature parity with upstream tantivy labels Jan 30, 2024
@imaurer
Copy link

imaurer commented Mar 13, 2024

Looks like FuzzyTermQuery has been implemented, but not available in the current release on PyPI. Curious if this project has a cadence for releases. Thanks!

e95a456

@cjrh
Copy link
Collaborator

cjrh commented Mar 14, 2024

Hi @imaurer, we don't have a set cadence of releases unfortunately. @wallies does our releases, I'm sure he'll get around to it within the next week or two.

@wallies
Copy link
Collaborator

wallies commented Mar 14, 2024

@cjrh @imaurer I was hoping tantivy would publish a new release so will could pull in some upstream fixes as well. I'll make a release within the next few days

@cjrh cjrh changed the title Support for other query method Support for all Tantivy query methods Apr 21, 2024
@aecio
Copy link
Contributor

aecio commented Apr 22, 2024

I just submitted a PR that exposes DisjunctionMaxQuery. Hopefully, someone can review and it can make it to the next release as well.

BTW, thanks for this great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-parity Feature parity with upstream tantivy help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants