-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider building abi3 wheels #80
Comments
It's a good idea, we should do this. |
fyi @wallies - since we're planning on a new release soon anyway maybe now is a good time to do this. |
Had a look. Sadly, |
@cjrh, @wallies, would you mind joining the #tantivy-py channel on the Quickwit Discord server. There have been many questions regarding |
Apparently there is some kind of fallback support for datetime described in this PR: PyO3/pyo3#3633. I need to look at it but perhaps there's a path for us. |
Indeed @Tpt contributed a fully abi3-compatible variant of PyO3's |
To reduce build effort and improve portability, PyO3 supports building in "abi3" mode where Python's stable ABI/API is used which makes the resulting binary wheels forward-compatible beginning at a specified Python version, e.g. wheels using the
abi3-py38
feature are compatible with Python 3.8 and later.This can cost some performance if there is a lot of back and forth between Rust and Python code, but whether that cost is significant for this extension is hard to say without measuring it.
The text was updated successfully, but these errors were encountered: