Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WARNING: redefining QVM::COMPILE-INSTRUCTION in DEFGENERIC #227

Open
stylewarning opened this issue Dec 20, 2019 · 0 comments
Open

WARNING: redefining QVM::COMPILE-INSTRUCTION in DEFGENERIC #227

stylewarning opened this issue Dec 20, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@stylewarning
Copy link
Member

warning i get when compiling
@stylewarning stylewarning added bug Something isn't working good first issue Good for newcomers labels Dec 20, 2019
notmgsk pushed a commit that referenced this issue Jul 5, 2021
@notmgsk
[#227] fix redefine warning for compile-instruction generic
e3e74dc 
Here are two of the modules as they were ordered in qvm's asd file:

  - (:file "mixed-state-qvm")
  - (:file "compile-gate")

Mixed-state-qvm has a defmethod on compile-instruction. Compile-gate
has the defgeneric as well as several more defmethods. The Lisp system
was creating a standin defgeneric for mixed-state-qvm when it was
loaded first, and so then when it loaded the explicit defgeneric in
compile-gate, it issued the warning

  WARNING: redefining QVM::COMPILE-INSTRUCTION in DEFGENERIC

Solution: just switch the order, placing mixed-state-qvm after
compile-gate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stylewarning