15 standardize linting #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
| ✅ BASH | shfmt | list_of_files | 1 | 1 | 0 | 0.02s | @sir-sigurd I'd like to standardize all our coding style conventions around megalinter automation. P.S. I fixed the execute bit, thanks for the catch. |
[GitHub Comment Reporter] Unable to post pull request comment: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/issues/comments#create-an-issue-comment"}.
To enable this function, please :
1. Create a Personal Access Token (https://docs.github.com/en/free-pro-team@latest/github/authenticating-to-github/creating-a-personal-access-token)
2. Create a secret named PAT with its value on your repository (https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-a-repository)3. Define PAT={{secrets.PAT}} in your GitHub action environment variables
[Updated Sources Reporter] copied 3 fixed source files in folder /github/workspace/megalinter-reports/updated_sources.
Download it from artifacts then copy-paste it in your local repo to apply linters updates
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
|
FYI, it seems like 'shfmt' really does want to remove the execute bit, which might be a security recommendation. Also, this made me realize I have no clue when "deploy.sh" is called, or by whom, so I have no idea how to test (or configure) it. Can you enlighten me? |
sir-sigurd
approved these changes
Aug 18, 2023
sir-sigurd
reviewed
Aug 18, 2023
| ), | ||
| ) | ||
| benchling_tenant = troposphere.Parameter( | ||
| "BenchlingTenant", | ||
| template=cft, | ||
| Type="String", | ||
| AllowedPattern=r"^[^/]+$", | ||
| Description="Benchling tenant name, i.e. $BenchlingTenant in " | ||
| + "https://$BenchlingTenant.benchling.com", | ||
| Description="Benchling tenant name, i.e. $BenchlingTenant in " + "https://$BenchlingTenant.benchling.com", |
There was a problem hiding this comment.
why not?
Suggested change
| Description="Benchling tenant name, i.e. $BenchlingTenant in " + "https://$BenchlingTenant.benchling.com", | |
| Description="Benchling tenant name, i.e. $BenchlingTenant in https://$BenchlingTenant.benchling.com", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.