-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Local timezone #310
Comments
Those seem like reasonable ideas, I'll have a go at implementing them. The change is going to require changing all existing files though, which is a pain. |
I've started looking into this, and unfortunately daylight savings time boundaries make it tricky. Just moving the timezone offset to a field by itself doesn't work, because sometimes an event will run over a DST boundary, e.g. from Your third suggestion of mapping cities to default timezone is possible (as part of the add event form), though is more of a pain without timezone names being stored in events. |
Ok, I see the edge cases 🤔 Would it be an option to still allow the start and end time to specify an offset? Then this could be used to disambiguate the rare edge cases while still not needing to care for almost all events. So my suggestions would just be a fallback for when there is no offset specified. This would also remove the need to migrate existing files. NB: As an organiser I would expect half of my audience to just understand the wrong time in those cases anyway — even if I list the time in an unambiguous way. 😂 |
#315 is now live, https://folkdance.page/add will automatically set the timezone based on the country and state. |
It’s a bit of a inconvenience to need to take care of time zones when creating the data for the YAML files. Even more so because dance events are usually in person at a specific place where the timezone to use is kind of obvious
I’d propose to …:
Europe/Vienna
) for this field instead of just offsets.Any of those would improve the editing experience.
The text was updated successfully, but these errors were encountered: