Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add uuid extension #517

Merged
merged 1 commit into from
Aug 7, 2024
Merged

feat: Add uuid extension #517

merged 1 commit into from
Aug 7, 2024

Conversation

rfhb
Copy link
Contributor

@rfhb rfhb commented Aug 7, 2024

This is a proposal to add uuid() functions as per source code here: https://www.sqlite.org/src/file?name=ext/misc/uuid.c&ci=tip. The documentation is updated, and simple tests are included. Local devtools::test() completed without errors.

I trust that users will welcome to be able to generate UUIDs within the database, as this is performant and can be part of SQL logic (such as in my use case). There do not seem to be risks or unintended consequences (e.g., footprint, performance, security aspects).

Possibly the same could be said about other extensions in the source repository; not sure if you plan for others to be included or a generic mechanism for compiling even with sources from outside the SQLite repository?

Many thanks for considering!

Copy link
Contributor

aviator-app bot commented Aug 7, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr krlmlr changed the title Proposal for adding uuid() feat: Add uuid extension Aug 7, 2024
@krlmlr
Copy link
Member

krlmlr commented Aug 7, 2024

Thanks, very useful!

@aviator-app aviator-app bot merged commit 694afe8 into r-dbi:main Aug 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants