Skip to content

Commit edb5fa9

Browse files
committed
Fix tests for devel DBItest
1 parent f37844f commit edb5fa9

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

.github/workflows/db.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ jobs:
5757
uses: actions/cache@v1
5858
with:
5959
path: ${{ env.R_LIBS_USER }}
60-
key: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-2-${{ hashFiles('.github/depends.Rds') }}
61-
restore-keys: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-2-
60+
key: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-${{ hashFiles('.github/depends.Rds') }}
61+
restore-keys: ${{ runner.os }}-${{ hashFiles('.github/R-version') }}-1-
6262

6363
- name: Install R system dependencies
6464
if: runner.os == 'Linux'

tests/testthat/test-MySQL.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ test_that("MySQL", {
2929
"quote_identifier_vectorized", # Can't implement until https://github.com/rstats-db/DBI/issues/71 is closed
3030
"roundtrip_logical", # Not an error, PostgreSQL has a logical data type
3131
"roundtrip_timestamp", # We explicitly want to set tzone to UTC regardless of input
32+
"roundtrip_time",
3233
"roundtrip_raw", #TODO
3334
"list_tables",
3435
".*_table_name",
@@ -51,6 +52,8 @@ test_that("MySQL", {
5152
"list_fields_wrong_table",
5253
"list_fields_quoted",
5354
"list_fields_object",
55+
"list_tables_quote",
56+
"list_objects_quote",
5457
NULL))
5558
DBItest::test_meta(c(
5659
"rows_affected_query", # The MySQL Driver returns 1 affected row

tests/testthat/test-PostgreSQL.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ test_that("PostgreSQL", {
9494
"quote_identifier_vectorized", # Can't implement until https://github.com/rstats-db/DBI/issues/71 is closed
9595
"quote_identifier_special", # TODO
9696
"roundtrip_timestamp", # We explicitly want to set tzone to UTC
97+
"roundtrip_time",
9798
"roundtrip_raw", #TODO
9899
"list_tables",
99100
".*_table_name",

tests/testthat/test-SQLite.R

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,11 @@ test_that("SQLite", {
4747
"roundtrip_logical", # Not an error
4848
"read_table", # #7
4949

50+
"exists_table_temporary",
51+
"list_tables_temporary",
52+
"list_objects_temporary",
53+
"list_fields_temporary",
54+
5055
# These work locally but fail on travis due to an old SQLite version
5156
"roundtrip_integer",
5257
"roundtrip_numeric.*",

0 commit comments

Comments
 (0)