From a73ddc1bd3e4055d71dc1c87e7ca339590dc4d1e Mon Sep 17 00:00:00 2001 From: Saranjeet Kaur Date: Wed, 4 Dec 2024 16:44:42 +0000 Subject: [PATCH 1/2] :building_construction: add PR template --- .github/PULL_REQUEST_TEMPLATE.md | 40 ++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..9cb7bc3f --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,40 @@ + +### Summary + + + +Fixes # + +*Lorem ipsum dolor sit amet, consectetur adipiscing.* + +### List of changes proposed in this PR (pull-request) + + + +* *Lorem ipsum dolor sit amet, consectetur adipiscing.* +* *Lorem ipsum dolor sit amet, consectetur adipiscing.* + +### Some housekeeping checks + +- [ ] If you have added a new chapter(s)/section(s) to the guide, have you update the [Quick start to the guide](https://contributor.r-project.org/rdevguide/introduction.html#quick-start-to-the-guide) accordingly? +- If you have added a new chapter(s) to the guide: + - [ ] Have you listed it (them) in the `_bookdown.yml`? + - [ ] Is the filename(s) for the new chapter(s) in lower case (except for when the letter `R` is used in the filename for referring to the R programming language)? + - [ ] Are the words in the filename(s) for the new chapter(s) separated (if required) by `-`? + +### What should a reviewer concentrate their feedback on? + + + +- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* +- [ ] Everything looks ok? + +### Acknowledging contributors + + + +- [ ] All contributors to this pull request are already named in the [table of contributors](https://github.com/r-devel/rdevguide/blob/main/README.md#contributors-) in the README file. +- [ ] The following people should be added to the [table of contributors](https://github.com/r-devel/rdevguide/blob/main/README.md#contributors-) in the README file: +- [ ] Use the [How to acknowledge contributors](https://github.com/r-devel/rdevguide/blob/main/HOWTO-acknowledge-contributors.md) to add new contributor(s) using the [All Contributors](https://allcontributors.org/) Bot. From 14af9a1085f7ac1884875c2981393abf54c15fdc Mon Sep 17 00:00:00 2001 From: Saranjeet Kaur Date: Wed, 4 Dec 2024 17:11:03 +0000 Subject: [PATCH 2/2] Apply suggestions from Heather's review Co-authored-by: Heather Turner --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9cb7bc3f..bd35703c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,22 +11,22 @@ Fixes # ### List of changes proposed in this PR (pull-request) - + * *Lorem ipsum dolor sit amet, consectetur adipiscing.* * *Lorem ipsum dolor sit amet, consectetur adipiscing.* ### Some housekeeping checks -- [ ] If you have added a new chapter(s)/section(s) to the guide, have you update the [Quick start to the guide](https://contributor.r-project.org/rdevguide/introduction.html#quick-start-to-the-guide) accordingly? +- [ ] If you have added a new chapter(s)/section(s) to the guide, have you updated the [Quick start to the guide](https://contributor.r-project.org/rdevguide/introduction.html#quick-start-to-the-guide) accordingly? - If you have added a new chapter(s) to the guide: - [ ] Have you listed it (them) in the `_bookdown.yml`? - - [ ] Is the filename(s) for the new chapter(s) in lower case (except for when the letter `R` is used in the filename for referring to the R programming language)? - - [ ] Are the words in the filename(s) for the new chapter(s) separated (if required) by `-`? + - [ ] Are the filename(s) for the new chapter(s) in lower case? + - [ ] Are the words in the filename(s) for the new chapter(s) separated by `-` (if required)? ### What should a reviewer concentrate their feedback on? - + - [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* - [ ] Everything looks ok?