-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor geoflow action fun args #262
Comments
eblondel
added a commit
that referenced
this issue
May 31, 2022
eblondel
added a commit
that referenced
this issue
Jun 1, 2022
eblondel
added a commit
that referenced
this issue
Jun 1, 2022
Are the global custom actions not concerned by this update ? As it still mandatory to have an "options" argument in the function ? (Line 517 of geoflow::initWorkflow https://github.com/eblondel/geoflow/blob/master/R/initWorkflow.R) |
All actions should be concerned by this code refactoring/harmonization |
eblondel
added a commit
to firms-gta/geoflow-tunaatlas
that referenced
this issue
Jun 12, 2023
eblondel
added a commit
to firms-gta/geoflow-tunaatlas
that referenced
this issue
Jun 12, 2023
eblondel
added a commit
to firms-gta/geoflow-tunaatlas
that referenced
this issue
Jun 12, 2023
eblondel
added a commit
to firms-gta/geoflow-tunaatlas
that referenced
this issue
Jun 12, 2023
eblondel
added a commit
to firms-gta/geoflow-tunaatlas
that referenced
this issue
Jun 12, 2023
eblondel
changed the title
Refactor geoflow action fun handling
Refactor geoflow action fun args
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Relates to #261
This is the current status regarding the way actions can be interfaced:
function
interface like:where
my_fun
should be the action id.This is highly criticizable and not really convenient for the user, for multiple reasons detailed below:
id
defined for the action.options
are not clear, especially for testing local actions, these are the action options. This 'argument' should be removed from the function interface. Theaction
definition should be made available. From there, options will be easily grab usingaction$options
, or using util to develop in Provide simple way to get action option value (selected, or default available) #261 which will then avoid re-writing action options default values in the action function, but inherit them from the action definition;Hence, any action (global embedded, global custom, local) will have to be designed within a function interface as follows:
In addition, for global embedded actions, an attempt will be made to create a separate folder 'actions' under the 'inst' folder
@abennici @juldebar @wheintz if you have any questions, feel free. I will anyway assist you in changes where needed
The text was updated successfully, but these errors were encountered: