Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undesirable_function_linter(unnamed_vector_of_functions) should "just work" #2536

Open
MichaelChirico opened this issue Mar 29, 2024 · 2 comments · May be fixed by #2791
Open

undesirable_function_linter(unnamed_vector_of_functions) should "just work" #2536

MichaelChirico opened this issue Mar 29, 2024 · 2 comments · May be fixed by #2791

Comments

@MichaelChirico
Copy link
Collaborator

Example:

entjos/TreeMineR#2

It would be much cleaner to just write undesirable_function_linter(dt_functions) and have undesirable_function_linter apply the defaults internally. Is there any reason not to allow this?

Ditto for undesirable_operator_linter().
@AshesITR
Copy link
Collaborator

Do you mean undesirable_function_linter("foo") should be equivalent to undersirable_function_linter(c(foo = NA))?

@MichaelChirico
Copy link
Collaborator Author

Yes (and for vectors of course)

@MichaelChirico MichaelChirico linked a pull request Feb 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unnamed entries "just work" in undesirable_function_linter (and for operators) r-lib/lintr
2 participants
@AshesITR @MichaelChirico