Move the cyclocomp namespace check into the factory #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warnings are easy to overlook - not the biggest fan of this approach. |
AshesITR
reviewed
Feb 25, 2025
Co-authored-by: AshesITR <alexander.rosenstock@web.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2785 +/- ##
==========================================
+ Coverage 99.57% 99.58% +0.01%
==========================================
Files 125 125
Lines 6840 6829 -11
==========================================
- Hits 6811 6801 -10
+ Misses 29 28 -1 ☔ View full report in Codecov by Sentry. |
AshesITR
reviewed
Feb 26, 2025
R/with.R
Outdated
| @@ -187,10 +187,11 @@ call_linter_factory <- function(linter_factory, linter_name, package) { | |||
| linter <- tryCatch( | |||
| linter_factory(), | |||
| error = function(e) { | |||
| cli_abort( | |||
There was a problem hiding this comment.
Maybe we should return a "disabled" linter here too? Probably I'm overthinking it. Reverting for now.
MichaelChirico
commented
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2777
Two notable changes accompany this:
linters_with_tags()(viacall_linter_factory()) warns instead of errors when a linter fails to build. Again we return the "dumb" linter in this case. This is not strictly needed thanks to only warning from the factory, but I think it's a better design anyway.Mostly in tests I've opted anyway for
skip()s, rather than an awkward construct where we optionallyexpect_warning(), or swap betweenexpect_warning()/expect_no_warning(), or ...This exercise also flushed out some more tests that are implicitly reading our main project .lintr file, fixing which increases their hermeticity.