Skip to content

Commit

Permalink
Merge branch 'main' into name-and-version-checks
Browse files Browse the repository at this point in the history
  • Loading branch information
wlandau committed Mar 6, 2024
2 parents 4af88e9 + e0e8700 commit f38365d
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 1 deletion.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Change the package name to `r.releases.internals`.
* Get RemoteSha hashes for checking versions (@jeroen, https://github.com/r-universe-org/help/issues/377).
* Makes `review_pull_requests()` robust to a package description with no URL listed.

# r.releases.utils 0.0.8

Expand Down
8 changes: 7 additions & 1 deletion R/assert_cran_url.R
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@ assert_cran_url <- function(name, url) {
return(invisible())
}
package <- result[["Package"]]
main_urls <- strsplit(result[["URL"]], ",\n|, |\n", perl = TRUE)[[1L]]
main_urls <- unlist(
strsplit(
as.character(result[["URL"]]),
",\n|, |\n",
perl = TRUE
)
)
bugs_url <- sub(
pattern = "/issues/*$",
replacement = "",
Expand Down
11 changes: 11 additions & 0 deletions tests/test-assert_package.R
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,17 @@ stopifnot(
)
)

stopifnot(
grepl(
"does not appear in its DESCRIPTION file published on CRAN",
r.releases.utils::assert_cran_url(
name = "assertthat",
url = "https://github.com/hadley/assertthat"
),
fixed = TRUE
)
)

stopifnot(
grepl(
"returned HTTP error",
Expand Down

0 comments on commit f38365d

Please sign in to comment.