Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose snapshot #35

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Propose snapshot #35

merged 7 commits into from
Aug 22, 2024

Conversation

wlandau
Copy link
Member

@wlandau wlandau commented Aug 21, 2024

@shikokuchuo, this PR adds a function propose_snapshot() which can run just after update_staging() to keep track of the active snapshot candidate. propose_snapshot() records all the packages which (1) are up to date in the universe, and (2) have no issues. Packages are recorded as (1) a universe-like snapshot.json file with the name, url, and SHA, and (2) a snapshot.url with the snapshot API URL which can be plugged directly into curl to download the snapshot. Note: this URL mentions individual packages, so it will be extremely long!

@wlandau wlandau self-assigned this Aug 21, 2024
@shikokuchuo
Copy link
Member

Oh this is exactly what I had in mind - you beat me to it! I'll try it out now. Hope you're getting enough rest!!

Copy link
Member

@shikokuchuo shikokuchuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the extent of my comments. Looks good!

R/propose_snapshot.R Show resolved Hide resolved
R/propose_snapshot.R Outdated Show resolved Hide resolved
R/propose_snapshot.R Outdated Show resolved Hide resolved
@wlandau
Copy link
Member Author

wlandau commented Aug 22, 2024

@shikokuchuo, I also just pushed a commit that exempts Production from WASM checks. From what I learned at Posit Conf, only about 60% of packages currently work on WASM, and it is unlikely that we can reasonably expect them all to be WASM-compliant for the next several years.

@wlandau wlandau merged commit f7b8ac4 into r-multiverse:main Aug 22, 2024
6 checks passed
@wlandau wlandau deleted the propose_snapshot branch August 22, 2024 12:58
@wlandau
Copy link
Member Author

wlandau commented Aug 22, 2024

Happy to report that all this is now up and running in https://github.com/r-multiverse/staging/blob/main/.github/workflows/staging.yaml! Next step is to see where we can host production. I will reach out to Posit and see if we can partner with the p3m people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants