You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds record_versions() which creates and updates a record (versions.json) of package versions and the highest version recorded so far. It also keeps track of the MD5 hashes, which I assume are guaranteed to update whenever the package source changes (currently looking for confirmation on that). record_versions() also writes version_issues.json which is a subset of the manifest containing packages for which either:
The current package release does not have the highest version number ever released for the package.
The package is at its highest version number, but that same version was previously released under a different MD5.
version_issues.json is written as its own file in order to help with r-multiverse/help#6 (cc @llrs). Only a small number of packages should have version issues, so a new releases::check_releases() function (or whatever we decide to call it) should be able to download the entirety of version_issues.json quickly. No need to support a whole web API just to scrape parts of the full versions.json.
r-multiverse/help#21 (comment) is really helpful. If those MD5s are brittle, then I agree we shouldn't use them here. Trouble is I don't know how to get the GitHub SHAs from the R-universe API. @shikokuchuo, do you know how?
Okay, so I added a check_hash argument just now. check_hash = FALSE allows us to do everything we can using the versions alone. This should unblock r-multiverse/help#6 from initial development while we think of something better for hashes..
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
record_versions()which creates and updates a record (versions.json) of package versions and the highest version recorded so far. It also keeps track of the MD5 hashes, which I assume are guaranteed to update whenever the package source changes (currently looking for confirmation on that).record_versions()also writesversion_issues.jsonwhich is a subset of the manifest containing packages for which either:Supports r-multiverse/help#21.