Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: state query error handling #123

Closed
Tracked by #132
Daanvdplas opened this issue Jul 23, 2024 · 1 comment · Fixed by #133
Closed
Tracked by #132

refactor: state query error handling #123

Daanvdplas opened this issue Jul 23, 2024 · 1 comment · Fixed by #133
Assignees
@Daanvdplas

Comments

@Daanvdplas
Copy link
Collaborator

Daanvdplas commented Jul 23, 2024 •
edited
Loading

Right now if you call a state query function (e.g. fn total_supply) and it is not allowed in the runtime (i.e. AllowedApiCall for RuntimeStateKeys #122) there is no error handling in api ink! library.

Edit: error handling was already implemented, the integration tests had to be refactored.
This was referenced Jul 23, 2024
Merged
Merged
@Daanvdplas Daanvdplas changed the title fix: state query error handling refactor: state query error handling Jul 26, 2024
@Daanvdplas Daanvdplas mentioned this issue Jul 26, 2024
Merged
@Daanvdplas Daanvdplas added question Further information is requested and removed question Further information is requested labels Jul 26, 2024
@Daanvdplas Daanvdplas linked a pull request Jul 26, 2024 that will close this issue
refactor: api integration tests #133
Merged
@Daanvdplas Daanvdplas self-assigned this Jul 26, 2024
@Daanvdplas Daanvdplas mentioned this issue Jul 30, 2024
Closed
@Daanvdplas
Copy link
Collaborator Author

Closed by #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Daanvdplas Daanvdplas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: api integration tests r0gue-io/pop-node
1 participant
@Daanvdplas