Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: weight for approve dispatchable in pallet-api/nonfungibles #463

Open
chungquantin opened this issue Feb 4, 2025 · 0 comments
Open

refactor: weight for approve dispatchable in pallet-api/nonfungibles #463

chungquantin opened this issue Feb 4, 2025 · 0 comments
Labels
good first issue Good for newcomers pallet

Comments

@chungquantin
Copy link
Collaborator

Discussion link: #432 (comment)

Originally, there was a weight benchmarking function for approve() dispatchable, however, the returned benchmarking result was unexpectedly high. Hence, we replace it with the approach in #460

This need to be revisited and refactored to resolve with a proper approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers pallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chungquantin