Disposing Connection after closing it with timeout causes deadlock

[lukebakken]

Discussed in #1758

^{Originally posted by JanEggers January 6, 2025}

Describe the bug

[TestMethod]
public async Task DisposeWhileCatchingTimeoutDeadlocksRepro()
{
    var factory = new ConnectionFactory
    {
        UserName = "rabbit",
        Password = "rabbit",
        HostName = "localhost",
        VirtualHost = "/",
        AutomaticRecoveryEnabled = true
    };

    var receiveConnection = await factory.CreateConnectionAsync();
    try
    {
        await receiveConnection.CloseAsync(TimeSpan.Zero);
    }
    catch (Exception e)
    {
    }

    // this blocks forever
    await receiveConnection.DisposeAsync();
}

Reproduction steps

see code

Expected behavior

Dispose should never block it must either throw or work

Additional context

Im currently migrating to version from 6.8.1 to 7.0 but this causes my tests to be stuck.

[lukebakken]

Hi @JanEggers, thanks for providing the code to reproduce the issue. You've probably found a bug, or a change in behavior around TimeSpan.Zero.

What is the intent of using TimeSpan.Zero in your code/tests? Do you intend it to mean "infinite timeout"?

[JanEggers]

The intend is aborting the connection and cleaning up the resources used during testing, similar code would also run while our app is shutting down.

So any guidance on what do instead would be apprecheated

btw thx for the quick response :)

[JanEggers]

think I found it myself using AbortAsync() instead of CloseAsync(TimeSpan.Zero) gives the expected behavior

[JanEggers]

AbortAsync(TimeSpan.Zero) seems to have the same issue.