Create cancellation token from timeout
#1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JanEggers - can you test this out? |
|
sure |
|
just had a look at your change. is there a reason you put the cancellationtokensource inside the extensions? I think it is better placed inside the method in the connection class itself. if someone calls the method on the connection and not the extensions there might still be an issue. |
|
@JanEggers good point, let me look at that. |
|
all of my tests are green again with this change, so looks good thx. |
Fixes #1759 When passing a timeout of 0, `DisposeAsync` would block forever after closing a connection. This change ensures that the timeout is used in a cancellation token.
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1759
branch
from
f29946d to
fa9bc43
Compare
michaelklishin
approved these changes
Feb 4, 2025
danielmarbach
approved these changes
Feb 4, 2025
michaelklishin
approved these changes
Feb 4, 2025
|
Thank you for the reviews @michaelklishin and @danielmarbach! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1759
When passing a timeout of 0,
DisposeAsyncwould block forever after closing a connection.This change ensures that the timeout is used in a cancellation token.