-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.1: Deprecate two OAuth 2 settings #2084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rabbitmq-website with Cloudflare Pages
|
6 tasks
MarcialRosales
force-pushed
the
switch-to-entra-id-v2
branch
from
October 3, 2024 07:28
baa2b3c
to
f16c65e
Compare
@MarcialRosales same here, can you please resolve the conflicts? |
michaelklishin
changed the title
Deprecate oauth2 settings
4.1: Deprecate two OAuth 2 settings
Oct 4, 2024
MarcialRosales
force-pushed
the
deprecate-oauth2-settings
branch
from
October 4, 2024 12:38
85eccba
to
c11e37d
Compare
michaelklishin
force-pushed
the
switch-to-entra-id-v2
branch
from
October 9, 2024 00:55
f16c65e
to
f7a7fb3
Compare
MarcialRosales
force-pushed
the
deprecate-oauth2-settings
branch
from
October 9, 2024 11:58
c11e37d
to
de87346
Compare
Conflicts: docs/oauth2-examples-entra-id/index.md
Conflicts: docs/oauth2-examples-entra-id/index.md docs/oauth2-examples-okta.md
And remove any reference to oauth_metadata_url
Conflicts: docs/oauth2-examples-entra-id/index.md
michaelklishin
force-pushed
the
deprecate-oauth2-settings
branch
from
October 10, 2024 01:25
d7aec1c
to
6373392
Compare
michaelklishin
added a commit
that referenced
this pull request
Oct 23, 2024
michaelklishin
added a commit
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements these two features:
auth_oauth2.jwks_url
and its corresponding erlang config entry rabbitmq-server#12239management.metadata_url
and move it toauth_oauth2.discovery_endpoint_path
rabbitmq-server#12237Only for 4.1.x
This PR should only be merged after this PR has been merged. and this PR has been rebased too.