Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verified fake for txkazoo client and Lock #1903

Open
manishtomar opened this issue Jun 24, 2016 · 1 comment
Open

Verified fake for txkazoo client and Lock #1903

manishtomar opened this issue Jun 24, 2016 · 1 comment
Labels
tech-debt

Comments

@manishtomar
Copy link
Contributor

manishtomar commented Jun 24, 2016 •
edited
Loading

#1887 (comment)

There should be a verified fake for txkazoo client and it's associated Lock object which should be used in related tests.
manishtomar added a commit that referenced this issue Jun 29, 2016
@manishtomar
lock acquired refactoring - thanks @glyph
6e3acf4 
moved calling _perform based on lock to a separate function with
effect. Using ZKCrudModel instead of mock (again thanks to @glyph) in
effect closing #1903. And renamed some functions.
@manishtomar
Copy link
Contributor Author

It should be structured so that the Fake implementation is hidden and its state can be inspected by an inspector object. See https://github.com/rackerlabs/otter/pull/1927/files#r75564061 and https://glyph.twistedmatrix.com/2015/05/separate-your-fakes-and-your-inspectors.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manishtomar