You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There have been occasions where a new config was required by convergence planner. This was added as new argument to planner requiring changes everywhere it is called including tests. Now, it looks like planner needs CLB health info and node OFFLINE timeout as arguments #1870. To avoid changing signature again I think planner should be:
where resources is simple object containing servers, lb_nodes, lbs or any other future resources and config is another object containing configuration like build_timeout, steps_limit, node_timeout or any other future values.
There have been occasions where a new config was required by convergence planner. This was added as new argument to planner requiring changes everywhere it is called including tests. Now, it looks like planner needs CLB health info and node OFFLINE timeout as arguments #1870. To avoid changing signature again I think planner should be:
where
resources
is simple object containingservers
,lb_nodes
,lbs
or any other future resources andconfig
is another object containing configuration likebuild_timeout
,steps_limit
,node_timeout
or any other future values.The text was updated successfully, but these errors were encountered: