Skip to content

Conversation

@gronke
Copy link
Contributor

@gronke gronke commented Jun 3, 2025

Localizes dates in Dutch, German and English (default) with custom functions.

Hardcoding the month names helps to avoid fiddling with Saxon and Java.

@gronke gronke requested a review from PeterMosmans June 3, 2025 19:24
Copy link
Contributor

@syrosh syrosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it's fine to go ahead with hard coded values. Maybe adding the Java way if we need to support more localization.

Copy link
Contributor

@PeterMosmans PeterMosmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, as it stands, this errors out if there's no date (yet) set:

Error at char 36 in xsl:value-of/@select on line 321 column 106 of meta.xslt:
  XPST0008  Variable date has not been declared (or its declaration is not in scope)

I'm thinking of whether we can support a default (?) language as fallback, in order to ensure backwards compatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants