Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why pass the pad!=0 for radiotap #9

Open
johnnylin110 opened this issue Oct 14, 2021 · 3 comments
Open

Why pass the pad!=0 for radiotap #9

johnnylin110 opened this issue Oct 14, 2021 · 3 comments

Comments

@johnnylin110
Copy link

Hello,
thanks for provide the parser for Radiotap
I have a question that in radiotap.py line 320-321
https://github.com/radiotap/python-radiotap/blob/master/radiotap/radiotap.py#L320
why pass the pad!=0 case for radiotap and return the 0,{}
In Wire-Shark , the packet with pad!=0 still has radiotap field and can parse the information the same as your function do.
So I wonder why pad!=0 can't parse in this case?

Thanks!

@bcopeland
Copy link
Contributor

bcopeland commented Oct 14, 2021 via email

@johnnylin110
Copy link
Author

johnnylin110 commented Oct 14, 2021

@bcopeland
Thanks for the prompt reply, I record by 802.11 Wi-Fi packet, for the packet I record, about half of the packets have pad.
I want to parse radiotap to fetch the data rate information. (normal data rate or VHT data rate), is there any other way to get the data rate information for the packet if we just pass the packet?
Sorry I can't give you the packet due to personal reason.

However, I also notice that, for the python code, the A-MPDU, and VHT part didn't have alignment,
https://github.com/radiotap/python-radiotap/blob/master/radiotap/radiotap.py#L157
https://github.com/radiotap/python-radiotap/blob/master/radiotap/radiotap.py#L170
in the introduction web https://www.radiotap.org/fields/defined, it says that VHT and A-MPDU need the alignment (2 for VHT, 4 for A-MPDU)
So Is the code right or the website right? because i also notice that the result parse by this code generate different results from Wire-Sharks ( it seems to have alignment on this two field)

@bcopeland
Copy link
Contributor

bcopeland commented Oct 15, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants