-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why pass the pad!=0 for radiotap #9
Comments
On Wed, Oct 13, 2021 at 10:51:34PM -0700, johnnylin110 wrote:
Hello,
thanks for provide the parser for Radiotap
I have a question that in radiotap.py line 320-321
[https://github.com/radiotap/python-radiotap/blob/master/radiotap/radiotap.py#L320](url)
why pass the pad!=0 case for radiotap and return the 0,{}
In Wire-Shark , the packet with pad!=0 still has radiotap field and can parse the information the same as your function do.
So I wonder why pad!=0 can't parse in this case?
As I recall (been a while) the reason to check the pad was to avoid
parsing corrupted radiotap headers as there's no perfect way to tell whether
we have an actual header or just random garbage in front of a packet.
Do you have an example capture file where the pad is routinely non-zero?
…--
Bob Copeland %% https://bobcopeland.com/
|
@bcopeland However, I also notice that, for the python code, the A-MPDU, and VHT part didn't have alignment, |
On Thu, Oct 14, 2021 at 07:16:08AM -0700, johnnylin110 wrote:
However, I also notice that, for the python code, the A-MPDU, and VHT part didn't have alignment,
This is probably an omission and when I originally wrote it the fields were
aligned by happenstance on my hardware. You can just add the appropriate
align() call in the parse method, feel free to send a PR to fix.
…--
Bob Copeland %% https://bobcopeland.com/
|
Hello,
thanks for provide the parser for Radiotap
I have a question that in radiotap.py line 320-321
https://github.com/radiotap/python-radiotap/blob/master/radiotap/radiotap.py#L320
why pass the pad!=0 case for radiotap and return the 0,{}
In Wire-Shark , the packet with pad!=0 still has radiotap field and can parse the information the same as your function do.
So I wonder why pad!=0 can't parse in this case?
Thanks!
The text was updated successfully, but these errors were encountered: