You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 13, 2017. It is now read-only.
Upon updating journey from 1.0.3 to 1.0.4 test behaviour have changed in regard to subdomains.
Consider this test:
it"returns success for correct domain"do@request.host="something.example.com"get'show'response.shouldbe_successend
With 1.0.3 it get passes host data and subdomain constraints are evaluated. With 1.0.4 however get doesn't host data, resulting in different or not constraint match, which breaks behaviour completely.
Writing this test like this will work:
it"returns success for correct domain"doget'show',subdomain: "something"response.shouldbe_successend
However @request.host method allows for setting subdomains in shared examples, which we employ in our tests.