Skip to content
This repository was archived by the owner on Sep 13, 2017. It is now read-only.
This repository was archived by the owner on Sep 13, 2017. It is now read-only.

1.0.3 -> 1.0.4 update breaks @request.host in tests #41

@Slotos

Description

@Slotos

Hello

Upon updating journey from 1.0.3 to 1.0.4 test behaviour have changed in regard to subdomains.
Consider this test:

      it "returns success for correct domain" do
        @request.host = "something.example.com"
        get 'show'

        response.should be_success
      end

With 1.0.3 it get passes host data and subdomain constraints are evaluated. With 1.0.4 however get doesn't host data, resulting in different or not constraint match, which breaks behaviour completely.

Writing this test like this will work:

      it "returns success for correct domain" do
        get 'show', subdomain: "something"

        response.should be_success
      end

However @request.host method allows for setting subdomains in shared examples, which we employ in our tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions