Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user select their own vault id for inputs/outputs before deploying #273

Open
hardyjosh opened this issue Nov 14, 2024 · 0 comments
Open
Assignees

Comments

@hardyjosh
Copy link
Contributor

In the yaml right now we have orders

orders:
  arbitrum-wbtc-weth:
    network: arbitrum
    orderbook: arbitrum
    inputs:
      - token: arbitrum-wbtc
      - token: arbitrum-weth
    outputs:
      - token: arbitrum-wbtc
      - token: arbitrum-weth

If no vault ids are provided, they are randomly generated inside thegetAddOrderCalldata. that's why we need to decode the calldata and get the ids before we can do the deposits.

If they are provided, it looks like this:

orders:
  arbitrum-wbtc-weth:
    network: arbitrum
    orderbook: arbitrum
    inputs:
      - token: arbitrum-wbtc
         vault-id: 0x123
      - token: arbitrum-weth
         vault-id: 0x123
    outputs:
      - token: arbitrum-wbtc
         vault-id: 0x123
      - token: arbitrum-weth
         vault-id: 0x123

We want to allow users to choose their own vault ids. This should be an optional override you can make on the review screen. Put a small button (even could be styled as a greyed out link) that says "choose vault ids". Clicking that reveals a field where the user can enter an id.

Then, add the value to the yaml as above and ensure that modified yaml is the one passed to getAddOrderCalladata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants