Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata editor doesn't show form upon successful UUID load, clicking 'next' causes blank screen #498

Open
gordlin opened this issue Dec 30, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working Priority: Urgent This task should be grabbed before any others

Comments

@gordlin
Copy link
Member

gordlin commented Dec 30, 2024

Description

The latest merges to main seem to have completely broken the metadata editor. There are two major issues:

  • Upon entering a correct UUID into the load existing storylines product screen, the app indicates success but doesn't show the form.
  • If you somehow manage to click 'Next', the editor doesn't load in, and you get a blank screen.

Screenshots

After clicking load:
Image

After clicking 'next' OR directly entering UUID into URL (sometimes):
Image

NOTE: It doesn't load in after waiting, I tried

Steps to reproduce

  1. Go to the load existing storylines product screen
  2. Enter a UUID for an existing storylines product (e.g. 00000000-0000-0000-0000-000000000000)
  3. Click Load. You'll get the success toast, but the form and 'next' button won't show up. The user is now stuck.
  4. After fixing this issue, try clicking the 'Next' button. The editor won't load.

Expected behavior

Form and next button should show up after loading an existing UUID, and next button should load the editor.

Actual behavior

No form, no next button, no editor.

Possible solution

For the first issue, I think someone just messed with the loadStatus variable and put in the wrong value for success, since the form will only load on loadStatus === 'loaded'. Specifically this bit of code (metadata-editor.vue, function loadConfig):

if (this.loadExisting && !this.renamed) {
    this.loadStatus = 'waiting';
    Message.success(this.$t('editor.editMetadata.message.successfulLoad'));
} else {
    this.loadStatus = 'loaded';
}
@gordlin gordlin added Bug Something isn't working Priority: Urgent This task should be grabbed before any others labels Dec 30, 2024
@szczz
Copy link
Member

szczz commented Dec 30, 2024

Console grouse

Image

@RyanCoulsonCA
Copy link
Member

From the Slack channel,

My suspicion is that this is happening because the logo URL is 404ing now. In this PR I made a comment about how the editor doesn't load when an SVG logo returns a CORS error, and I think this is probably related.

After further investigation, removing the logo from the product config does in fact fix the issue with the editor crashing. We should probably look in to why the editor crashes if the image fails to load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: Urgent This task should be grabbed before any others
Projects
None yet
Development

No branches or pull requests

3 participants