Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update custom CAPIProvider version #96

Open
cpinjani opened this issue Sep 27, 2024 · 2 comments
Open

Unable to update custom CAPIProvider version #96

cpinjani opened this issue Sep 27, 2024 · 2 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@cpinjani
Copy link
Collaborator

What steps did you take and what happened?

  • Install turtles v0.11.0 on Rancher v2.9 via Rancher Dashboard
  • Install custom providers eg.
  1. kubeadm-control-plane using YAML (do not provide version)
  2. kubeadm-bootstrap using CAPI-UI extension, it creates using version
spec:
  configSecret:
    name: custom-credentials-xtczv
  features:
    clusterResourceSet: true
    clusterTopology: true
    machinePool: true
  fetchConfig:
    url: >-
      https://github.com/kubernetes-sigs/cluster-api/releases/v1.4.6/bootstrap-components.yaml
  name: kubeadm
  type: bootstrap
  variables: {}
  **version: v1.4.6**

image

  • Upgrade turtles to v0.12

kubeadm-control-plane is auto-upgraded to v1.7.3
message: Updated to latest v1.7.3 version

kubeadm-bootstrap stays on v1.4.6 and unable to upgrade using ClusterctlConfig
message: Provider version update available. Current latest is v1.7.3

What did you expect to happen?

CAPIProvider version should be auto-upgraded or User able to upgrade custom CAPIProvider version

How to reproduce it?

No response

Rancher Turtles version

v.0.12

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug

@salasberryfin
Copy link

Thanks for reporting this @cpinjani and for helping me out with reproducing it. I was able to experience the behavior described in the issue. Since user provided a specific version during provider installation I think it would make sense that they are required to manually update to a newer version, as automatic updates may not align with their needs.

In this case I managed to update the version manually by editing the CAPIProvider resource, which I think should be the source of truth in this situation. Perhaps what is missing here is a way to let users know that there are newer versions available and a way for them to update the provider via UI, equivalent to what we have in Turtles. What do you think?

image

For cases where user did not configure a specific version, it's sensible that Turtles takes care of applying latest version available.

@cpinjani
Copy link
Collaborator Author

cpinjani commented Nov 8, 2024

@salasberryfin Users get message that there are newer versions available from CAPIProvider status.
Agreed there should be a way for them to get informed & update the provider via UI similar to below.

image

status:
  conditions:
    - lastTransitionTime: '2024-11-08T06:44:05Z'
      reason: MinimumReplicasAvailable
      status: 'True'
      type: Ready
    - lastTransitionTime: '2024-11-08T07:01:20Z'
      message: Provider version update available. Current latest is v1.7.7
      reason: UpdateAvailable
      severity: Info
      status: 'False'
      type: CheckLatestVersionTime

@cpinjani cpinjani transferred this issue from rancher/turtles Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants