Skip to content

Commit

Permalink
Adding image check to pull request workflow and bumping scripts version
Browse files Browse the repository at this point in the history
  • Loading branch information
lucasmlp committed Aug 17, 2023
1 parent 4995cd1 commit 117ac85
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,12 @@ jobs:
run: sudo make validate

- name: Run Hull tests
run: cd tests && go test -v ./...
run: cd tests && go test -v ./...

- name: Check container images
run: make check-images
if: startsWith(github.ref, 'refs/heads/upstream/release-v')
continue-on-error: true
env:
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ remove:
forward-port:
./scripts/forward-port

TARGETS := prepare patch clean clean-cache charts list index unzip zip standardize validate template regsync
TARGETS := prepare patch clean clean-cache charts list index unzip zip standardize validate template regsync check-images

$(TARGETS):
@./scripts/pull-scripts
Expand Down
2 changes: 1 addition & 1 deletion scripts/version
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
set -e

CHARTS_BUILD_SCRIPTS_REPO=https://github.com/rancher/charts-build-scripts.git
CHARTS_BUILD_SCRIPT_VERSION="${CHARTS_BUILD_SCRIPT_VERSION:-v0.4.4}"
CHARTS_BUILD_SCRIPT_VERSION="${CHARTS_BUILD_SCRIPT_VERSION:-v0.4.6}"

0 comments on commit 117ac85

Please sign in to comment.