Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating RBAC verbs to include create #2794

Closed
wants to merge 2 commits into from
Closed

Updating RBAC verbs to include create #2794

wants to merge 2 commits into from

Conversation

geethub97
Copy link
Contributor

Issue: rancher/rancher#40253

Problem

Solution

Testing

Repro steps in the GH ticket linked above are valid.

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

joshmeranda
joshmeranda approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@joshmeranda joshmeranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geethub97 geethub97 marked this pull request as draft July 28, 2023 18:40
@geethub97 geethub97 changed the base branch from dev-v2.7 to dev-v2.8 August 14, 2023 23:11
@geethub97 geethub97 changed the base branch from dev-v2.8 to dev-v2.7 August 14, 2023 23:12
@geethub97
Copy link
Contributor Author

Closing this in favor of #2862.

@geethub97 geethub97 closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmeranda joshmeranda joshmeranda approved these changes

@prachidamle prachidamle Awaiting requested review from prachidamle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geethub97 @joshmeranda