Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.8] System upgrade controller support for k8s 1.27 #2915

Merged
merged 2 commits into from
Aug 31, 2023
Merged

[v2.8] System upgrade controller support for k8s 1.27 #2915

merged 2 commits into from
Aug 31, 2023

Conversation

thatmidwesterncoder
Copy link
Contributor

@thatmidwesterncoder thatmidwesterncoder commented Aug 29, 2023 •
edited
Loading

Issue: rancher/rancher#41791

Problem

system-upgrade-controller currently doesn't support k8s 1.27

Solution

Bump the supported range to include 1.27

Testing

In the linked issue.

Engineering Testing

Manual Testing

Installation of the chart on k8s 1.26 cluster since 1.27 is not available in rancher yet.

Automated Testing

n/a

QA Testing Considerations

n/a

Regressions Considerations

n/a

Backporting considerations

n/a

@thatmidwesterncoder thatmidwesterncoder changed the title System upgrade controller k8s 1.27 [v2.8] System upgrade controller support for k8s 1.27 Aug 29, 2023
@thatmidwesterncoder thatmidwesterncoder requested review from jiaqiluo and a team August 30, 2023 15:16
@thatmidwesterncoder thatmidwesterncoder marked this pull request as ready for review August 30, 2023 15:16
@jiaqiluo jiaqiluo requested a review from a team August 30, 2023 16:09
a-blender
a-blender approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@a-blender a-blender left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thatmidwesterncoder Just want to make sure these were intentional

  • The SUC appVersion was patched to v1.13.1. I don't personally know the versioning for SUC so if @jiaqiluo thinks that's correct then cool.
  • Bump chart version to 103.1.0 - via semver, this means there are new features/enhancements correct?

@thatmidwesterncoder
Copy link
Contributor Author

@a-blender

The SUC appVersion was patched to v1.13.1. I don't personally know the versioning for SUC so if @jiaqiluo thinks that's correct then cool.

Yes - I bumped it to v0.13.1 to match the image tag released, Jack corrected me on that here: rancher/system-charts#594 (comment)

Bump chart version to 103.1.0 - via semver, this means there are new features/enhancements correct?

I couldn't tell you all of the features that were in it - but I assumed since we're jumping 2 minor versions 0.11.0 -> 0.13.1 it would probably be worth a minor bump. I can change it to patch though if that isn't necessary.

@a-blender
Copy link
Contributor

a-blender commented Aug 31, 2023 •
edited
Loading

@jiaqiluo Nah since appVersion needs to match the image tag rancher/system-charts#594 (comment) that's fine. And I was referring to the chart version per the patch comment :)

@thatmidwesterncoder thatmidwesterncoder merged commit 16fb846 into rancher:dev-v2.8 Aug 31, 2023
6 checks passed
@thatmidwesterncoder thatmidwesterncoder deleted the system_upgrade_controller_k8s_1.27 branch August 31, 2023 19:34
thatmidwesterncoder added a commit to thatmidwesterncoder/charts that referenced this pull request Aug 31, 2023
@thatmidwesterncoder
Revert "Merge pull request rancher#2915 from thatmidwesterncoder/syst…
242c49c 
…em_upgrade_controller_k8s_1.27"

This reverts commit 16fb846, reversing
changes made to 18fddb4.
This was referenced Oct 23, 2023
Closed
Merged
lucasmlp pushed a commit that referenced this pull request Oct 24, 2023
@thatmidwesterncoder @lucasmlp
Revert "Merge pull request #2915 from thatmidwesterncoder/system_upgr…
5dbfb4e 
…ade_controller_k8s_1.27"

This reverts commit 16fb846, reversing
changes made to 18fddb4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaqiluo jiaqiluo jiaqiluo approved these changes

@a-blender a-blender a-blender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thatmidwesterncoder @a-blender @jiaqiluo