Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.8] Feature Charts batch release for rancher-backup, rancher-gatekeeper and sriov #3208

Merged
merged 24 commits into from
Nov 1, 2023

Conversation

lucasmlp
Copy link
Contributor

@lucasmlp lucasmlp commented Nov 1, 2023

Issues:

rancher-backup:

rancher-gatekeeper:

rancher-sriov:

Charts Checklist (built for v0.5.2 charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
For k8s 1.27 support - apps and feature charts
removing doNotRelease: true
changing kube-version to support 1.27
adding rancher-gatekeeper with version to release.yaml
make prepare
make patch
make clean
@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
follow-up to bcab8844d807ee1db558533248273ccd492874bb

Signed-off-by: Michael Fritch <mfritch@suse.com>
Signed-off-by: Michael Fritch <mfritch@suse.com>
Signed-off-by: Michael Fritch <mfritch@suse.com>
Copy link

github-actions bot commented Nov 1, 2023

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rancher rancher deleted a comment from github-actions bot Nov 1, 2023
@lucasmlp lucasmlp requested a review from a team November 1, 2023 20:25
@rohitsakala rohitsakala added the regsync-ready PR ready to sync images with prime registry label Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rohitsakala rohitsakala merged commit 4d40599 into release-v2.8 Nov 1, 2023
5 checks passed
@rohitsakala rohitsakala deleted the feat-2-8-batch-7 branch November 1, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants