-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v2.8] Feature Charts batch release for fleet #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmlp
force-pushed
the
feat-v2.8/batch-10
branch
from
November 7, 2023 20:47
268a046
to
30f1fbe
Compare
lucasmlp
force-pushed
the
feat-v2.8/batch-10
branch
from
November 7, 2023 20:53
f798dc7
to
87017c5
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
lucasmlp
changed the title
[release-v2.8] Feature Charts batch release for fleet and longhorn
[release-v2.8] Feature Charts batch release for fleet
Nov 7, 2023
diogoasouza
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe the version should be 103.0.0+up0.9.0 instead of 103.1.0+up0.9.0
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
fleet:
Charts Checklist (built for v0.5.2 charts-build-scripts)
Checkpoint 0: Validate
release.yaml
Validation steps:
release.yaml
DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.release.yaml
IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.Checkpoint 1: Compare contents of assets/ to charts/
Validation steps:
make unzip
to regenerate thecharts/
from scratch, thengit diff
to check differences betweenassets/
andcharts/
yields NO differences or innocuous differences.IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!
Checkpoint 2: Compare assets against index.yaml
Validation steps: