Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.8] OOB Charts release for NeuVector 2.7.1 and NeuVector Monitoring 2.7.1 #3394

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

lucasmlp
Copy link
Contributor

@lucasmlp lucasmlp commented Jan 31, 2024

Issues:

Pull-Requests:

Charts Checklist (built for v0.5.2 charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

@lucasmlp lucasmlp force-pushed the oob-jan-31/v2.8 branch 3 times, most recently from 8d0ec6b to 3e78389 Compare January 31, 2024 18:06
@rancher rancher deleted a comment from github-actions bot Jan 31, 2024
@rancher rancher deleted a comment from github-actions bot Jan 31, 2024
@rancher rancher deleted a comment from github-actions bot Jan 31, 2024
@rancher rancher deleted a comment from github-actions bot Jan 31, 2024
@lucasmlp lucasmlp requested a review from a team January 31, 2024 18:11
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rancher rancher deleted a comment from github-actions bot Feb 1, 2024
@lucasmlp lucasmlp merged commit cae810a into release-v2.8 Feb 5, 2024
6 checks passed
@lucasmlp lucasmlp deleted the oob-jan-31/v2.8 branch February 5, 2024 22:17
@lucasmlp lucasmlp restored the oob-jan-31/v2.8 branch February 5, 2024 22:41
@lucasmlp lucasmlp added the regsync-ready PR ready to sync images with prime registry label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants