-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump helm.sh/helm/v3 from 3.12.1 to 3.14.1 in /tests #3472
Bump helm.sh/helm/v3 from 3.12.1 to 3.14.1 in /tests #3472
Conversation
Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.12.1 to 3.14.1. - [Release notes](https://github.com/helm/helm/releases) - [Commits](helm/helm@v3.12.1...v3.14.1) --- updated-dependencies: - dependency-name: helm.sh/helm/v3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
A newer version of helm.sh/helm/v3 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once hull tests
are passing this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a strong reason for updating the helm dependency?
I feel like this should be carefully done to avoid exactly what's happening here. Breaking the hull tests. If there's no strong reason for updating the helm dependency and hull still doesn't have a working version with helm v3.14.1, I would close this PR.
I don't think so. To be honest this has taken way more time than it is worth. Regarding the hull tests, I was under the impression that @vardhaman22's team knew about them, so would be able to update them. I think that's right? Either way, I believe this PR is superseded by #3495. Closing. Please reopen if this is wrong. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps helm.sh/helm/v3 from 3.12.1 to 3.14.1.
Release notes
Sourced from helm.sh/helm/v3's releases.
... (truncated)
Commits
e8858f8
validation fix3fc9f4b
Improve release action69dcc92
bump version to27921d0
Merge pull request #12698 from mattfarina/fix-10920c042264
Fix issues when verify generation readiness was mergedb299359
Merge pull request #10920 from muang0/readiness-generation-check7fd0804
Merge pull request #12617 from porridge/dynamic-client1ccde5a
Merge pull request #10677 from antoinedeschenes/lint-kube-version6e5332e
fix test to use the default code's k8sVersionMinor869c1d2
lint: Add --kube-version flag to set capabilities and deprecation rulesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.