Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.7] Batch Charts release for rancher-csp-adapter, neuvector and neuvector-monitor #3473

Merged
merged 5 commits into from
Feb 26, 2024

Conversation

nicholasSUSE
Copy link
Collaborator

@nicholasSUSE nicholasSUSE commented Feb 15, 2024

Issues:

rancher-csp-adapter:

neuvector:

neuvector-monitor:

Charts Checklist (built for v0.5.2 charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

selvamt94 and others added 2 commits February 23, 2024 21:21
Co-authored-by: selvamt94 <sthangaraj@neuvector.com>
Co-authored-by: selvamt94 <sthangaraj@neuvector.com>
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@nicholasSUSE nicholasSUSE requested review from lucasmlp and a team February 24, 2024 00:24
@lucasmlp lucasmlp changed the title [release-v2.7] Batch Charts release for rancher-csp-adapter [release-v2.7] Batch Charts release for rancher-csp-adapter, neuvector and neuvector-monitoring Feb 26, 2024
@lucasmlp lucasmlp changed the title [release-v2.7] Batch Charts release for rancher-csp-adapter, neuvector and neuvector-monitoring [release-v2.7] Batch Charts release for rancher-csp-adapter, neuvector and neuvector-monitor Feb 26, 2024
@nicholasSUSE nicholasSUSE marked this pull request as ready for review February 26, 2024 18:00
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lucasmlp lucasmlp added the regsync-ready PR ready to sync images with prime registry label Feb 26, 2024
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp merged commit 249db96 into release-v2.7 Feb 26, 2024
5 checks passed
@lucasmlp lucasmlp deleted the 1st-batch-release-2.7.11 branch February 26, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants