-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev-v2.8] Bump rancher-monitoring/rancher-monitoring to use new rancher/shell #3656
[dev-v2.8] Bump rancher-monitoring/rancher-monitoring to use new rancher/shell #3656
Conversation
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some chart validation errors as well. Run make validate
and make-check-release-yaml
locally, these will help
packages/rancher-monitoring/rancher-monitoring/templates/crd-template/values.yaml
Outdated
Show resolved
Hide resolved
9040dfc
to
fa5e72f
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pointed out some changes to be made on release.yaml
. Otherwise PR looks good to me.
One thing that I would also comment is: rancher-monitoring 103.0.3+up45.31.1
is released in Rancher v2.8. IMO there's no need to bump the chart beyond 103.0.4. You could follow this workflow after 103.0.3+up45.31.1
was released:
- Bump the chart to
103.0.4+up45.31.1-RC1
- Make your changes in
packages
folder - commit
make charts
- commit
- Open and merge PR
- If the result is not satisfactory, make another bump to RC2
- Make your changes in
packages
folder - commit
make charts
- commit
- Open and merge PR
- Repeat until the result is satisfactory
- Open PR to un-RC the chart
Please tell me what you think about his workflow. I would like to know more about the feature chart owner team's needs to rework our developing documentation 🙂
fa5e72f
to
991a624
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
991a624
to
2e6a80c
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
2e6a80c
to
8c386e8
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
8c386e8
to
10ad183
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
10ad183
to
9e2aa94
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
9e2aa94
to
11ddf8e
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
11ddf8e
to
91f5b60
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
91f5b60
to
12c3f5f
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Validation TemplateWhat was fixed, or what change have occurredThe version of Areas or cases that should be testedUpgrading from an older version of
What areas could experience regressionsThe upgrade jobs that run for Are the repro steps accurate/minimal?Yes. |
Issue:
SURE-7080
Problem
See original issue
Solution
See original issue
Testing
Engineering Testing
Manual Testing
Installed
103.0.3+up45.31.1
via Apps, upgraded to103.0.4+up45.31.1
, then subsequently to103.0.5-rc1+up45.31.1
.Upon upgrade to
103.0.5-rc1+up45.31.1
I can observe shellv0.1.23
in use as expected.Automated Testing
QA Testing Considerations
Regressions Considerations
Backporting considerations