Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.7] unrc cis 4.4.0 #3676

Merged
merged 4 commits into from
Mar 20, 2024
Merged

[dev-v2.7] unrc cis 4.4.0 #3676

merged 4 commits into from
Mar 20, 2024

Conversation

vardhaman22
Copy link
Contributor

@vardhaman22 vardhaman22 commented Mar 20, 2024 •
edited
Loading

Issue:

rancher/rancher#44741

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@vardhaman22 vardhaman22 requested review from a team as code owners March 20, 2024 13:58
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

mitulshah-suse
mitulshah-suse approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@mitulshah-suse mitulshah-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@vardhaman22 vardhaman22 merged commit 745fad7 into rancher:dev-v2.7 Mar 20, 2024
6 checks passed
nicholasSUSE pushed a commit to nicholasSUSE/charts that referenced this pull request Mar 21, 2024
@vardhaman22 @nicholasSUSE
[dev-v2.7] unrc cis 4.4.0 (rancher#3676)
3bb382a
@nicholasSUSE nicholasSUSE mentioned this pull request Mar 26, 2024
Closed
4 tasks
lucasmlp pushed a commit that referenced this pull request Mar 27, 2024
@vardhaman22 @lucasmlp
[dev-v2.7] unrc cis 4.4.0 (#3676)
437a984
@lucasmlp lucasmlp mentioned this pull request Mar 27, 2024
Merged
6 tasks
@lucasmlp lucasmlp added regsync-ready PR ready to sync images with prime registry and removed regsync-ready PR ready to sync images with prime registry labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitulshah-suse mitulshah-suse mitulshah-suse approved these changes

@nicholasSUSE nicholasSUSE nicholasSUSE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vardhaman22 @mitulshah-suse @nicholasSUSE @lucasmlp